Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown lexer improvements #1623

Merged

Conversation

@Leistungsabfall
Copy link
Contributor

@Leistungsabfall Leistungsabfall commented Dec 7, 2020

This is a series of improvements to the Markdown Lexer:

  • Fenced code was not recognized when it contained empty lines
  • Inline code was not recognized after bulleted list entry (e.g. * `code` )
  • Bold and italics were not recognized when surrounded with non-space char (e.g. (**foo**))
  • There is no way to recognize code indented by 4 spaces using regex only - so remove the error-prone detection
@Leistungsabfall Leistungsabfall changed the title Feature/improve markdown lexer Markdown lexer improvements Dec 7, 2020
@Leistungsabfall Leistungsabfall force-pushed the feature/improve-markdown-lexer branch from 4ed70c6 to 13ba7e3 Dec 8, 2020
@Anteru Anteru added this to the 2.8 milestone Dec 8, 2020
@gerner
Copy link
Contributor

@gerner gerner commented Dec 17, 2020

I verified that the perf issue described in #1617 is fixed by this change with identical output from pygmentize on the test file. If this PR gets merged then my proposed fix in #1618 is unnecessary.

@Anteru Anteru removed this from the 2.8 milestone Jan 6, 2021
@Anteru Anteru added this to the 2.7.4 milestone Jan 6, 2021
@Anteru Anteru merged commit 811f1a6 into pygments:master Jan 6, 2021
13 checks passed
@Anteru Anteru self-assigned this Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants