-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMDGPU ISA Lexer #1626
Merged
Merged
AMDGPU ISA Lexer #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please add an example file -- can be a trivial shader, but there should be one to allow the automated testing to pick this lexer up. |
@Anteru I added a simple shader as test. |
Anteru
requested changes
Jan 18, 2021
This was referenced Mar 8, 2021
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements a basic lexer for the AMDGPU ISA definition.
This is based on the GPUOpen VS Code extension to be found here: https://github.com/GPUOpen-Tools/vscode_extensions/blob/master/amd-gcn-isa/syntaxes/isa.tmLanguage
I tested it with some ISA examples found on GPUOpen (https://gpuopen.com/learn/porting-detroit-2/). Please have a look at it.