Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Coq-related bug #678 #1648

Merged
merged 3 commits into from Jan 4, 2021
Merged

Fix Coq-related bug #678 #1648

merged 3 commits into from Jan 4, 2021

Conversation

@ghost
Copy link

@ghost ghost commented Dec 26, 2020

No description provided.

@Anteru
Copy link
Collaborator

@Anteru Anteru commented Dec 27, 2020

Is the MULTILINE flag intentional? I don't see rules requiring it, and I'd rather not have flags added with no effect.

Maximilian Wuttke added 2 commits Dec 28, 2020
Catch-all lexing for `Name.Builtin.Pseudo`, as in the lean lexer.

This fixes #678.
@ghost
Copy link
Author

@ghost ghost commented Dec 28, 2020

Good point! I've updated the commit.

In fact, I just copied the flag from the Lean lexer, without knowing what it does... Now, I have looked up the doc for MULTILINE, and I tested the code. I don't know why MULTILINE was used in Lean.

@Anteru
Copy link
Collaborator

@Anteru Anteru commented Dec 28, 2020

Thanks! As to why it was used in Lean: Probably a bug there as well :)

Would you mind adding an unit test to make sure one case you care about is working correctly now?

@Anteru Anteru added this to the 2.7.4 milestone Jan 4, 2021
@Anteru Anteru merged commit c01ccfe into pygments:master Jan 4, 2021
13 checks passed
@ghost ghost deleted the coq-unicode branch Jan 4, 2021
@Anteru Anteru assigned Anteru and unassigned Anteru Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant