Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports single quote strings in AutoItLexer #1667

Merged
merged 3 commits into from
Feb 8, 2021
Merged

Conversation

trdean1
Copy link
Contributor

@trdean1 trdean1 commented Jan 7, 2021

Fix for issue #1663

@trdean1 trdean1 mentioned this pull request Jan 7, 2021
@Anteru
Copy link
Collaborator

Anteru commented Feb 6, 2021

Can you please add a test for it?

@Anteru Anteru self-assigned this Feb 6, 2021
@Anteru Anteru added this to the 2.8 milestone Feb 6, 2021
@Anteru Anteru linked an issue Feb 6, 2021 that may be closed by this pull request
@trdean1
Copy link
Contributor Author

trdean1 commented Feb 7, 2021

Done - I have added a line to tests/examplefiles/autoit/autoit_submit.au3 that tests this case and updated the corresponding output file after verifying the output from pytest was correct.

@Anteru
Copy link
Collaborator

Anteru commented Feb 7, 2021

Thanks. Something doesn't look right though: The ' appears both as Token.String, and then again with the rest of the string. That doesn't seem quite right to me, as you'd get ''boo; bar; "baz"'' when you paste them back together. Can you please double check that the output looks correct?

@trdean1
Copy link
Contributor Author

trdean1 commented Feb 7, 2021

I think it looks correct to me. The ''s on line 177 of autoit_submit.au3.output are just displaying the token as a string. Compare to lines 14-16 which holds the output of "http://localhost:8080". This becomes

'"'   Literal.String
'http://localhost:8080'  Literal.String
'"'   Literal.String

@Anteru
Copy link
Collaborator

Anteru commented Feb 8, 2021

Ah, you're right, my bad! Thanks, merged for the next release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with AutoIT Parser
2 participants