Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __END_LINE__ to Crystal syntax highlighting #1670

Merged
merged 1 commit into from Jan 9, 2021
Merged

Conversation

@rhysd
Copy link
Contributor

@rhysd rhysd commented Jan 8, 2021

I found __END_LINE__ magic constant is missing in syntax highlighting for Crystal language.

https://crystal-lang.org/reference/syntax_and_semantics/constants.html

I found `__END_LINE__` magic constant is missing in syntax highlighting for Crystal language.
@rhysd
Copy link
Contributor Author

@rhysd rhysd commented Jan 8, 2021

I want to have review by @oprypin

oprypin
oprypin approved these changes Jan 8, 2021
Copy link
Contributor

@oprypin oprypin left a comment

Good find!

previous_def forall out uninitialized __DIR__ __FILE__ __LINE__
__END_LINE__
Copy link
Contributor

@oprypin oprypin Jan 8, 2021

The way that the lines are split looks weird, but this is technically the most correct way, so nothing to do here.

Copy link
Contributor Author

@rhysd rhysd Jan 9, 2021

I'm not familiar with code style of this project, but all lines seem to be limited within 90 characters. If this is put at L173, L173 will exceed 90 chars. Please let me know if my understanding is not correct.

Copy link
Collaborator

@Anteru Anteru Jan 9, 2021

Our "desired" target line length is 90 characters, so this looks fine. The 90 character rule hasn't been enforced but it's a general guideline.

@Anteru Anteru added this to the 2.7.4 milestone Jan 9, 2021
@Anteru Anteru merged commit 894a5bc into pygments:master Jan 9, 2021
13 checks passed
@Anteru
Copy link
Collaborator

@Anteru Anteru commented Jan 9, 2021

Merged, good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants