Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gruvbox styles #1763

Merged
merged 2 commits into from
May 2, 2021
Merged

Add gruvbox styles #1763

merged 2 commits into from
May 2, 2021

Conversation

kevna
Copy link
Contributor

@kevna kevna commented Mar 31, 2021

Added styles gruvbox-dark and gruvbox-light based on the famous vim theme from morhetz.

Gruvbox is not my property but it is MIT licensed so there shouldn't be any licensing problem using it under BSD.

@Anteru
Copy link
Collaborator

Anteru commented Apr 4, 2021

Thanks for the contribution! Can you please update the CHANGES file as well to mention this new addition?

@Anteru Anteru added this to the 2.9 milestone Apr 4, 2021
@Anteru Anteru added the changelog-update Items which need to get mentioned in the changelog label Apr 4, 2021
@Anteru Anteru added the update needed Waiting for an update from the PR/issue creator label Apr 4, 2021
@Anteru Anteru removed changelog-update Items which need to get mentioned in the changelog update needed Waiting for an update from the PR/issue creator labels May 2, 2021
@Anteru Anteru merged commit f0d433d into pygments:master May 2, 2021
@Anteru
Copy link
Collaborator

Anteru commented May 2, 2021

Merged, thanks for your contribution!

@brave1984
Copy link

brave1984 commented May 18, 2021

Hi @Anteru! I have discovered a bug in pygments.css ( gruvbox-dark mode ):

.highlight { background: #282828; }

Fix it:

.highlight { background: #282828;  color: #ebdbb2; }

@Anteru Anteru self-assigned this May 18, 2021
@kevna kevna deleted the gruvbox_theme branch June 2, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add morhetz's "gruvbox" theme to the styles list. [Feature Request]
3 participants