Skip to content

Lexer for new language Elpi#1894

Merged
Anteru merged 4 commits into
pygments:masterfrom
gares:lexer-elpi
Dec 12, 2021
Merged

Lexer for new language Elpi#1894
Anteru merged 4 commits into
pygments:masterfrom
gares:lexer-elpi

Conversation

@gares

@gares gares commented Sep 8, 2021

Copy link
Copy Markdown
Contributor

Well, the title says it all.

@gares

gares commented Sep 16, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for running CI!
I did fix the check and tests. I could not run make check locally, so maybe the copyright banner is still wrong.

@gares

gares commented Sep 27, 2021

Copy link
Copy Markdown
Contributor Author

Thanks again for running CI.
This time I need help understanding the results, since the failure seems to be about the HTML backend which I did not touch, and about a missing pyflakes which seems unrelated as well.

@blu-base

Copy link
Copy Markdown
Contributor

I think the failed make check is only because the copyrighted period is expected to be 2006-2021.
The other tests seem to have failed due to timeouts. maybe they are not related with your PR.

@Anteru Anteru self-assigned this Oct 11, 2021
@gares

gares commented Oct 11, 2021

Copy link
Copy Markdown
Contributor Author

OK, I fixed the copyright.

@Anteru

Anteru commented Nov 21, 2021

Copy link
Copy Markdown
Collaborator

Hm, I can't re-run the workflow, which is weird :(

@gares

gares commented Nov 27, 2021

Copy link
Copy Markdown
Contributor Author

@blu-base can you unblock this please?

@blu-base

Copy link
Copy Markdown
Contributor

Sorry, @gares , I can't. I am just a contributor myself.

@Anteru

Anteru commented Nov 28, 2021

Copy link
Copy Markdown
Collaborator

This is broken somewhere else. I need to run this manually to merge but I need to find some spare time to work on this.

@birkenfeld birkenfeld closed this Nov 28, 2021
@birkenfeld birkenfeld reopened this Nov 28, 2021
@birkenfeld

Copy link
Copy Markdown
Member

Hey the old "close and open" trick still works 🎆

@Anteru

Anteru commented Nov 28, 2021

Copy link
Copy Markdown
Collaborator

What the ...?

@birkenfeld

Copy link
Copy Markdown
Member

I think the "rerun" feature somehow depends on details of the old runs, and GitHub doesn't keep those around that long. What happens on "close and reopen" or if someone pushes some new changes is a completely fresh run.

Comment thread pygments/lexers/elpi.py Outdated
Comment thread pygments/lexers/elpi.py
Comment thread pygments/lexers/elpi.py Outdated
Comment thread tests/snippets/elpi/test_pred.txt
@Anteru

Anteru commented Nov 28, 2021

Copy link
Copy Markdown
Collaborator

@birkenfeld This somehow passed the tests despite producing an Error token. Do you happen to know what is going on here? I thought we never allow Error tokens to be produced.

@birkenfeld

Copy link
Copy Markdown
Member

Strange indeed, maybe it isn't caught anymore when it has been "blessed" as correct with the output file.

The easiest way to fix this is probably to add the raiseonerror filter.

@birkenfeld

Copy link
Copy Markdown
Member

Ah, the snippets series of tests does explicitly allow errors. I think this is correct, since you also should be able to check that erroneous inputs do give error tokens.

Not much to fix here except closely read the blessed output for new contributions ...

@gares

gares commented Nov 28, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for the review, I'll try to fix that tomorrow!

@gares

gares commented Nov 29, 2021

Copy link
Copy Markdown
Contributor Author

hopefully done

@gares

gares commented Dec 9, 2021

Copy link
Copy Markdown
Contributor Author

Sorry for the slow reaction. I've updated the golden since I now tag spaces with Text.Whitespace instead of just Text

@gares gares requested a review from Anteru December 9, 2021 17:19
@gares

gares commented Dec 10, 2021

Copy link
Copy Markdown
Contributor Author

OK, thanks for running CI again. This time it is green.

@Anteru Anteru added this to the 2.11.0 milestone Dec 12, 2021
@Anteru Anteru merged commit a502df0 into pygments:master Dec 12, 2021
@gares gares deleted the lexer-elpi branch December 12, 2021 17:40
@gares

gares commented Dec 12, 2021

Copy link
Copy Markdown
Contributor Author

Wow, thanks!

@Anteru

Anteru commented Dec 12, 2021

Copy link
Copy Markdown
Collaborator

Thanks for the contribution and sorry it took so long to merge. This quarter has been unusually busy in terms of contributions overall!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants