Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize Whitespace token - regarding #1905 #1911

Merged
merged 5 commits into from Oct 9, 2021

Conversation

blu-base
Copy link
Contributor

@blu-base blu-base commented Oct 8, 2021

This PR modernizes the following lexers regarding usage of Whitespace Token for whitespace characters in the context of #1905.

  • Diff
  • Make
  • Actionscript
  • Bare
  • Business

including the respective example file outputs


The Business(cobol) lexer is only a partial sucess. There are some complex regex which i didn't want to unravel and would likely be beyond the scope of the related compaign (#1905). Since the demand might be really small for this lexer, this might be opened in a separate issue with help wanted?

@Anteru
Copy link
Collaborator

Anteru commented Oct 9, 2021

Thanks a lot! Yes, I wouldn't worry about getting everything perfect to be honest -- this is already a huge improvement and perfection will be likely never achieved anyways without some fully automated enforcement.

@Anteru Anteru added this to the 2.11.0 milestone Oct 9, 2021
@Anteru Anteru self-assigned this Oct 9, 2021
@Anteru Anteru added the changelog-update Items which need to get mentioned in the changelog label Oct 9, 2021
@Anteru Anteru removed the changelog-update Items which need to get mentioned in the changelog label Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants