Fix unreadable dark styles by adding missing colors #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some dark styles did not define a color for every token type,
resulting in black text (the browser default for text) on dark
backgrounds (defined by the styles) unless the web page had some
CSS to remedy that like:
body { color: white; background: black; }
We however don't want the readability of styles to rely on external CSS.
Part of pygments#1718. Fixes some unreadable styles reported in pygments#1526.
7 tasks
|
Merged, thanks a lot! |
Anteru
added
the
changelog-update
Anteru
removed
the
changelog-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit fixes some completely unreadable styles (due to missing colors):
Before:
After:
(same for stata-dark & rrt)
The second commit slightly changes the color of numbers for the sas style so that it meets WCAG AA. I'd post a screen but the change is so small that I don't think you can actually see any difference.
Ideally merge these without squashing.