Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unreadable dark styles by adding missing colors #1955

merged 2 commits into from Nov 14, 2021


Copy link

The first commit fixes some completely unreadable styles (due to missing colors):



(same for stata-dark & rrt)

The second commit slightly changes the color of numbers for the sas style so that it meets WCAG AA. I'd post a screen but the change is so small that I don't think you can actually see any difference.

Ideally merge these without squashing.

Some dark styles did not define a color for every token type,
resulting in black text (the browser default for text) on dark
backgrounds (defined by the styles) unless the web page had some
CSS to remedy that like:

  body { color: white; background: black; }

We however don't want the readability of styles to rely on external CSS.

Part of pygments#1718. Fixes some unreadable styles reported in pygments#1526.
@Anteru Anteru merged commit d37c02b into pygments:master Nov 14, 2021
Copy link

Anteru commented Nov 14, 2021

Merged, thanks a lot!

@Anteru Anteru added this to the 2.11.0 milestone Nov 14, 2021
@Anteru Anteru added the changelog-update Items which need to get mentioned in the changelog label Nov 14, 2021
@Anteru Anteru removed the changelog-update Items which need to get mentioned in the changelog label Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants