-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc. SchemeLexer improvements #2060
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM in general. Can the small test file be moved to |
Move string parsing to a dedicated state so it can recognize string escapes. Add support for various kinds of escapes.
Many number literals were not recognized previously, such as fractions, infinities, hex and complex literals.
This enriches the space of recognized builtins. Note that this also fixes the space after a builtin being included in the token.
Previously, #; awaited an S-expression but could not cope with a simple datum like a number literal. While at it, also support R6RS brackets for S-expressions.
Highlighting as Keyword.Declaration is consistent with the RacketLexer.
Done. |
@birkenfeld Does this PR still need an update on my side? Does it look OK now? Sorry for being insistent :-) |
No, LGTM, sorry for dropping the ball. Thanks for the PR! |
birkenfeld
added
the
changelog-update
Items which need to get mentioned in the changelog
label
Feb 8, 2022
Thank you! |
Anteru
removed
the
changelog-update
Items which need to get mentioned in the changelog
label
Feb 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#;
,#:keywords
.(For history readability, it would be ideal if the commits were merged without squashing.)