-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elpi: fix catastrophic backtracking #2061
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reformatting makes it basically impossible to see what has really changed.
Please don't apply black
to the Pygments codebase, as you can see we have a pretty different style.
OK, I'll back the formatting out. Note, though, that it is in a separate commit for the purpose of review (I've been trained rigorously to use atomic commits, but maybe that is not usual here?). |
As far as I can see, the formatting changes in the first commit ("minor changes") which also has a bunch of other (useful) things? |
Of course it's useful, but even with atomic commits I wouldn't expect to see a wholesale reformatting in a PR to fix a bug :-) |
I have refactored this PR to include only the bugfix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Closes #2053