Added Berry Lexer#2070
Conversation
Added Berry Lexer with example file and passed test output. _mapping.py regenerated.
When def is used in an anonymouse function it was being classified as a function name not Keyword.Declaration.
This reverts commit efe4ecc.
This reverts commit 9e2dc8a.
This reverts commit f655a8f.
Added berry lexer, example file, and tested against lexer with no errors. Regenerated _mapping.py to include berry lexer.
jeanas
left a comment
jeanas
left a comment
There was a problem hiding this comment.
Thanks. Most of my comments are mundane, be sure to test the fix for catastrophic backtracking though.
1. Added license header 2. Added doc string 3. Ran make check - OK 4. Streamlined regexes 5. Fixed catastrophic backtracking
|
Thanks for the feedback and suggestions. Hopefully I have done the requested changes correctly. The HTML and test output looks good. |
|
Thanks for the updates; there are still a few unresolved threads and one new (easy) one. |
|
And two more:
|
1) versionadded changed to 2.12.0 2) def regex now handles names containing 'def' 3) Single line comment simplified 4) Changed Operator.Word -> Keyword
|
Added Berry to doc/languages.rst. I pushed a commit with the .DS_Store file deleted that I accidentally pushed in a previous commit. |
jeanas
left a comment
jeanas
left a comment
There was a problem hiding this comment.
Looks good to me. @birkenfeld Leaving on review right now in case you want to take a look at the updates.
birkenfeld
left a comment
birkenfeld
left a comment
There was a problem hiding this comment.
LGTM, just noted a little inconsistency where you use rf'...{_name}' in some places and explicit '...' + _name in others. But that's not a big deal.
|
Right. @Beormund, do you have the time to address that minor issue before we merge this? |
Done! |
|
Then thanks for the patience! |
3 participants
Added berry lexer, example file, and tested against lexer with no errors. Regenerated _mapping.py to include berry lexer.