java multiline highlighting based on issue 1858 #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanas
requested changes
May 9, 2022
There was a problem hiding this comment.
On the code level this looks good to me, but you need to write a test. Please add a file under tests/snippets/java/ containing a small sample of Java code with a text block. Then use pytest --update-goldens tests/snippets/java/ in order to generate the output appended to the file. After that, reopen the file and read the token output to check it's correct. If all's well, commit it and run pytest to perform a full round of testing. Thanks.
|
Thanks! I love this test :-) |
jeanas
added
changelog-update
jeanas
removed
the
changelog-update
This was referenced Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have implemented what we thought to be multiline support, and would appreciate any feedback regarding implementation/commenting and any supporting documentation you would like from us.