Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objective-J: fix catastrophic backtracking in comment regex #2225

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

jeanas
Copy link
Contributor

@jeanas jeanas commented Sep 6, 2022

This use of *? was both incorrect and catastrophically backtracking
when embedding this regex into a larger regex with a trailing pattern,
since it could match much more than intended and try exponentially
many positions in that process.

This use of *? was both incorrect and catastrophically backtracking
when embedding this regex into a larger regex with a trailing pattern,
since it could match much more than intended and try exponentially
many positions in that process.
@jeanas
Copy link
Contributor Author

jeanas commented Sep 13, 2022

WDYT @Anteru @birkenfeld?

@birkenfeld
Copy link
Member

LGTM.

@jeanas jeanas merged commit 513f8fc into pygments:master Sep 15, 2022
@jeanas jeanas deleted the objj-cataback branch September 15, 2022 13:02
@Anteru Anteru added this to the 2.14.0 milestone Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants