Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jsonnet support #2239

Merged
merged 9 commits into from
Sep 25, 2022
Merged

Add Jsonnet support #2239

merged 9 commits into from
Sep 25, 2022

Conversation

abentley
Copy link
Contributor

@abentley abentley commented Sep 18, 2022

This is my first code contribution to pygments, a Jsonnet lexer: https://jsonnet.org/

I wasn't sure how to handle copyright statements et al, but I'm happy to go along with whatever you like.

In addition to the supplied example file, I've ensured it could highlight the contents of the official tutorial without error (and in most cases updated the example file to replicate the initial failures).

I'm happy for any & all suggestions.

@abentley
Copy link
Contributor Author

Is any there any further info I can provide? It may be helpful to know that Jsonnet is used for Infrastructure As Code purposes, especially generating config files like Kubernetes manifests. For example, kube-prometheus from the Prometheus Operator project supports deploying Prometheus via Jsonnet.

@jeanas
Copy link
Contributor

jeanas commented Sep 21, 2022

No, please just wait a bit. This project has many PRs so it can take some time until a maintainer reviews one, but it will happen.

pygments/lexers/jsonnet.py Outdated Show resolved Hide resolved
pygments/lexers/jsonnet.py Outdated Show resolved Hide resolved
pygments/lexers/jsonnet.py Outdated Show resolved Hide resolved
pygments/lexers/jsonnet.py Outdated Show resolved Hide resolved
pygments/lexers/jsonnet.py Outdated Show resolved Hide resolved
pygments/lexers/jsonnet.py Outdated Show resolved Hide resolved
pygments/lexers/jsonnet.py Show resolved Hide resolved
pygments/lexers/jsonnet.py Outdated Show resolved Hide resolved
pygments/lexers/jsonnet.py Outdated Show resolved Hide resolved
pygments/lexers/jsonnet.py Outdated Show resolved Hide resolved
pygments/lexers/jsonnet.py Outdated Show resolved Hide resolved
Copy link
Contributor

@jeanas jeanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments...

pygments/lexers/jsonnet.py Show resolved Hide resolved
pygments/lexers/jsonnet.py Outdated Show resolved Hide resolved
pygments/lexers/jsonnet.py Show resolved Hide resolved
pygments/lexers/jsonnet.py Outdated Show resolved Hide resolved
@jeanas jeanas merged commit a283694 into pygments:master Sep 25, 2022
@jeanas
Copy link
Contributor

jeanas commented Sep 25, 2022

Thanks!

@abentley
Copy link
Contributor Author

Thanks for all the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants