Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#: recognize Operators as such, fix split-up numeric literals #2257

Merged
merged 1 commit into from
Oct 22, 2022

Conversation

birkenfeld
Copy link
Member

No description provided.

CHANGES Outdated
@@ -23,6 +23,7 @@ Version 2.14.0
* C family (C, C++ and many others): fix an issue where a chunk would
be wrongly recognized as a function definition due to braces in
comments (#2210)
* C#: fix number and operator recognition (#2256)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* C#: fix number and operator recognition (#2256)
* C#: fix number and operator recognition (#2257)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So better PR number instead of issue number?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, this is what I usually do but I don't mind either way.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add both the issues and the PR to all entries in CHANGES.

@birkenfeld birkenfeld merged commit a9b5fac into master Oct 22, 2022
@birkenfeld birkenfeld deleted the issue2256 branch October 22, 2022 20:31
@Anteru Anteru added this to the 2.14.0 milestone Oct 31, 2022
@Anteru Anteru added the changelog-update Items which need to get mentioned in the changelog label Oct 31, 2022
@jeanas jeanas removed the changelog-update Items which need to get mentioned in the changelog label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants