Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept colon(s) in YAML key names #2277

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

gdubicki
Copy link
Contributor

as it's ok according to the YAML specs and is widely used in the real world, f.e. in Puppet's Hiera (https://puppet.com/docs/puppet/7/hiera_quick.html#values_common_data)

@birkenfeld
Copy link
Member

This also accepts question marks, and it allows leading colons; is that intended?

as it's ok according to the YAML specs and is widely used in the real world,
f.e. in Puppet's Hiera (https://puppet.com/docs/puppet/7/hiera_quick.html#values_common_data)
@gdubicki gdubicki force-pushed the accept_colon_in_yaml_key_name branch from f8ea9ab to 3a63ee1 Compare November 14, 2022 11:52
@gdubicki
Copy link
Contributor Author

Thanks for a super-fast response @birkenfeld! 😊

The former was not intended, I fixed it now.

The latter was intended as it's the same as having a colon at any other place in the key name. I added a test for that.

@birkenfeld
Copy link
Member

Looks good, thanks!

@birkenfeld birkenfeld merged commit 9aa5fc0 into pygments:master Nov 14, 2022
@gdubicki gdubicki deleted the accept_colon_in_yaml_key_name branch November 14, 2022 14:00
@Anteru Anteru added this to the 2.14.0 milestone Dec 30, 2022
@gdubicki gdubicki restored the accept_colon_in_yaml_key_name branch January 3, 2023 20:04
@gdubicki gdubicki deleted the accept_colon_in_yaml_key_name branch January 3, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants