fix solidity lexer not picking up many of the operators (e.g. boolean and) #2292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birkenfeld
reviewed
Dec 3, 2022
| @@ -59,7 +59,7 @@ class SolidityLexer(RegexLexer): | |||
| (datatype, Keyword.Type), | |||
| include('constants'), | |||
| (r'[a-zA-Z_]\w*', Text), | |||
| (r'[!<=>+*/-]', Operator), | |||
| (r'[~!%^&*+=|?:<>/-]', Operator), | |||
There was a problem hiding this comment.
: is now recognized as both Operator and Punctuation - which makes more sense?
There was a problem hiding this comment.
good catch. it is somewhat ambiguous. : can be used in the shorthand if operator a ? b : c or also in structs like {x : y}. I would stick with Operator.
birkenfeld
added
the
changelog-update
|
Thanks! Tests are happy too, so let's go. |
Anteru
removed
the
changelog-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the lexer for Solidity would not pick up boolean operators. Odd that nobody noticed this. To fix it I switched to the same regex for operators in the solidity lexer as in the
CFamilyLexer. I updated the testcase with a function that covers all the operators I am aware of.