-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading APDL lexer #2314
Upgrading APDL lexer #2314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fails the CI as you need to run pytest --update-goldens tests/snippets/apdl
to update the golden test output.
@jean-abou-samra I have implemented the new changes. Feel free to re-trigger CI. Btw, I was trying that the keywords are only at the beginning of each line. I tried to add |
You would need |
Hi @jean-abou-samra, I'm not sure if I explained myself correctly. I would like that the keywords are only matched when they are at the beginning of the line. |
You said you tried to add |
Ohhh... ok ok... Let's add it then. |
Nope. Because if you do Please, check the commit that I pushed. It's not the only approach, but it should work. |
I see.... I checked the lastest commits and I'm happy with the result :). I'm happy to merge it. Thank a lot! |
Fixing some parsing issues (dots mainly).
Upgraded theme.
Before:
After:
Close #2315