-
Notifications
You must be signed in to change notification settings - Fork 720
Add LightbulbStyle #2474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LightbulbStyle #2474
Conversation
Thanks for the contribution! Unfortunately, your style doesn't pass the WCAG recommendation for contrast, is there any chance you can bump the contrast? Dark theme or not, we do want to maintain some level of accessibility, and often times only small tweaks are needed to get there. |
Looks good, thanks: |
This PR says merged but I don't see anything matching |
“lightbulb” |
Oops, I'd intended to write this in #2440, which I now see was declined. So only one new style for 2.16.0 then? |
FWIW, #2240 wasn't declined, but somehow the author decided (for reasons that are not clear to me) to close the PR and even delete the source branch. |
Sorry I didn't mean to imply who declined the PR, just the general term used in my parts. Too bad; new themes are fun. |
A minimal dark theme based on the Lightbulb theme for VSCode.