Skip to content

Add LightbulbStyle #2474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 18, 2023
Merged

Add LightbulbStyle #2474

merged 4 commits into from
Jul 18, 2023

Conversation

ykrx
Copy link
Contributor

@ykrx ykrx commented Jul 15, 2023

A minimal dark theme based on the Lightbulb theme for VSCode.

Screenshot 2023-07-17 at 3 00 14 AM

@Anteru
Copy link
Collaborator

Anteru commented Jul 16, 2023

Thanks for the contribution! Unfortunately, your style doesn't pass the WCAG recommendation for contrast, is there any chance you can bump the contrast? Dark theme or not, we do want to maintain some level of accessibility, and often times only small tweaks are needed to get there.

@Anteru Anteru added the A-theming area: changes to themes label Jul 16, 2023
@jeanas
Copy link
Contributor

jeanas commented Jul 18, 2023

Looks good, thanks:

@jeanas jeanas merged commit ab41859 into pygments:master Jul 18, 2023
@Anteru Anteru added this to the 2.16.0 milestone Jul 18, 2023
@numist
Copy link

numist commented Aug 8, 2023

This PR says merged but I don't see anything matching eclipse in the output of get_all_styles()… what is the name of this new style?

@jeanas
Copy link
Contributor

jeanas commented Aug 8, 2023

“lightbulb”

@numist
Copy link

numist commented Aug 8, 2023

Oops, I'd intended to write this in #2440, which I now see was declined.

So only one new style for 2.16.0 then?

@jeanas
Copy link
Contributor

jeanas commented Aug 8, 2023

FWIW, #2240 wasn't declined, but somehow the author decided (for reasons that are not clear to me) to close the PR and even delete the source branch.

@numist
Copy link

numist commented Aug 9, 2023

Sorry I didn't mean to imply who declined the PR, just the general term used in my parts.

Too bad; new themes are fun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theming area: changes to themes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants