Skip to content

Conversation

@vanillajonathan
Copy link
Contributor

Adds a lexer for the PRQL query language.

PRQL is a modern language for transforming data — a simple, powerful, pipelined SQL replacement.
https://prql-lang.org/
https://github.com/PRQL/prql

@Anteru
Copy link
Collaborator

Anteru commented Sep 14, 2023

Hello! This needs a test file before we can continue, look at the contribution page.

@Anteru
Copy link
Collaborator

Anteru commented Sep 15, 2023

Thanks for updating the _mapping file etc., but please do add an example file as well under /examplefiles.

@Anteru
Copy link
Collaborator

Anteru commented Sep 16, 2023

Thanks for the updates! Before we do burn down a forest here running CI, can you make sure to run the checks locally? Is there anything preventing you from using tox? I need to manually approve the CI run, and it's fairly simple stuff to fix that can be all checked locally.

@vanillajonathan
Copy link
Contributor Author

I can use tox but I am a bit new to this, I hadn't used it before.

@Anteru
Copy link
Collaborator

Anteru commented Sep 16, 2023

pip install tox (in the virtual environment you use for development) and then tox, tox -e check, and possibly tox -e mapfiles (to regenerate them)

@Anteru
Copy link
Collaborator

Anteru commented Sep 17, 2023

prql.py is missing the correct copyright info. It has to be 2006-2023, not just 2023.

@vanillajonathan
Copy link
Contributor Author

@Anteru I've updated the copyright into.

@Anteru Anteru added the A-lexing area: changes to individual lexers label Sep 23, 2023
@Anteru Anteru added this to the 2.17 milestone Sep 23, 2023
@Anteru
Copy link
Collaborator

Anteru commented Sep 23, 2023

Merged, thanks!

@Anteru Anteru merged commit 9ebec7d into pygments:master Sep 23, 2023
@vanillajonathan vanillajonathan deleted the patch-1 branch September 23, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-lexing area: changes to individual lexers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants