Add lexer for Soong (Android.bp) config files #2659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just came back from travel, looking into this now. |
|
Thanks @Anteru. I fixed up the |
Anteru
requested changes
Mar 26, 2024
|
Thanks for the review, @Anteru! Your comment about whitespace helped me realize there was a deficiency in my previous version (multi-line lists weren't handled correctly). I've corrected this and added a test. Please take another look! |
jeanas
requested changes
Mar 29, 2024
|
Thanks @jeanas. All comments have been resolved. |
copybara-service bot
pushed a commit
to google/pigweed
that referenced
this pull request
Oct 23, 2024
A lexer for Soong (Android.bp) was added to Pygments in version 2.18.0: * pygments/pygments#2659 * https://github.com/pygments/pygments/releases/tag/2.18.0 Pigweed upgraded to Pygments 2.18.0 in commit 9a52966 Change-Id: Id7e239bb80db20e1707026be6f931734eaa70cee Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/243880 Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com> Reviewed-by: Carlos Chinchilla <cachinchilla@google.com> Commit-Queue: Jonathon Reinhart <jrreinhart@google.com> Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a lexer for
Android.bpfiles which are used by the Soong Android build system.https://source.android.com/docs/setup/build
Here is an example of a full
Android.bpfile:platform/frameworks/base/Android.bp.