Skip to content

Add Rell lexer - #2914

Merged
Anteru merged 18 commits into
pygments:masterfrom
alexj136:rell-lexer
Jul 24, 2025
Merged

Add Rell lexer#2914
Anteru merged 18 commits into
pygments:masterfrom
alexj136:rell-lexer

Conversation

@alexj136

@alexj136 alexj136 commented Jun 20, 2025

Copy link
Copy Markdown

Add a lexer for the Rell language.

Alex Jeffery added 15 commits June 19, 2025 17:41
Alex Jeffery
Added skeleton for a Rell lexer, and some implementation. Work in pro…
c364ec5 
…gress.
Alex Jeffery
Improve rell lexer, add test file.
1ebc717
Alex Jeffery
Improved rell lexer, moved example rell file to correct location.
e978367
Alex Jeffery
Fix error scanning minus (-) due to lack of escaping backslash.
a7a008b
Alex Jeffery
Reorder and fiddle with regexes to fix some bugs.
e65db49
Alex Jeffery
Add goldens file.
d2bffb2
Alex Jeffery
Added some comments to the example file.
34f04c8
Alex Jeffery
Fix bug handling multiline comments.
1d79c17
Alex Jeffery
Update goldens after fixing comments.
4be6a2f
Alex Jeffery
Update PR number in release notes.
a91cbe7
Alex Jeffery
Rell lexer: remove deprecated keywords.
02c7525
Alex Jeffery
Tweak the token types a bit to improve the look.
ca62ede
Alex Jeffery
Different variable token type for function names and member accesses.…
7cd9d20 
… Add example to test it. Update goldens.
Alex Jeffery
Use Name token type for normal variables.
84da071
Alex Jeffery
Fixed bug handling extend functions that don't have an explicit name.
c88cbda
Anteru
Anteru requested changes Jul 19, 2025
View reviewed changes
Comment thread pygments/lexers/rell.py Outdated
Comment thread pygments/lexers/rell.py Outdated
Anteru
Anteru requested changes Jul 19, 2025
View reviewed changes
Comment thread pygments/lexers/rell.py Outdated
alexj136
alexj136 commented Jul 22, 2025
View reviewed changes

@alexj136 alexj136 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the review @Anteru. I addressed 2 of your 3 comments, just need a bit of clarification on the last item.

Comment thread pygments/lexers/rell.py Outdated
Comment thread pygments/lexers/rell.py Outdated
Comment thread pygments/lexers/rell.py Outdated
@alexj136
alexj136 requested a review from Anteru July 22, 2025 10:24
@alexj136

alexj136 commented Jul 23, 2025

Copy link
Copy Markdown
Author

Thanks again @Anteru, I've addressed your last comment and fixed the tox check failure.

@alexj136 alexj136 mentioned this pull request Jul 24, 2025
Closed
@Anteru
Anteru merged commit 3c6b176 into pygments:master Jul 24, 2025
15 checks passed
@Anteru Anteru added the A-lexing area: changes to individual lexers label Jul 24, 2025
@Anteru Anteru added this to the 2.20.0 milestone Jul 24, 2025
@Anteru

Anteru commented Jul 24, 2025

Copy link
Copy Markdown
Collaborator

Merged, thanks!

asifbabaasifbab113-gif

This comment was marked as spam.

Sign in to view

agngnw1-ops

This comment was marked as spam.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Anteru Anteru Awaiting requested review from Anteru
3 more reviewers
@asifbabaasifbab113-gif asifbabaasifbab113-gif asifbabaasifbab113-gif left review comments
@agngnw1-ops agngnw1-ops agngnw1-ops left review comments
@RespectTH RespectTH RespectTH approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-lexing area: changes to individual lexers

Projects

None yet

Milestone

2.20.0

Development

Successfully merging this pull request may close these issues.

5 participants

@alexj136 @Anteru @asifbabaasifbab113-gif @agngnw1-ops @RespectTH