From 826193f68c91865764fd8687d669eab2bdec864d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oliver=20Dahl=C3=A9n?= Date: Fri, 16 Apr 2021 19:41:20 +0200 Subject: [PATCH 1/2] Annotation This annotation could of saved me probably 1 hour. I thought the attach_callbacks would attach my back end callbacks that are set before in glfw. But I misunderstood it. A change to the argument name can be done aswell. Like attach_default_callbacks, or attach_pre_set_callbacks --- imgui/integrations/glfw.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/imgui/integrations/glfw.py b/imgui/integrations/glfw.py index e128f041..1a180df1 100644 --- a/imgui/integrations/glfw.py +++ b/imgui/integrations/glfw.py @@ -7,9 +7,8 @@ from . import compute_fb_scale from .opengl import ProgrammablePipelineRenderer - class GlfwRenderer(ProgrammablePipelineRenderer): - def __init__(self, window, attach_callbacks=True): + def __init__(self, window, attach_callbacks=True: "False to use your own callbacks"): super(GlfwRenderer, self).__init__() self.window = window From 12ddc443812f1044d53b3c402c9f86f462578a68 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oliver=20Dahl=C3=A9n?= <66334947+Oliver-Dahlen@users.noreply.github.com> Date: Sat, 17 Apr 2021 12:46:06 +0200 Subject: [PATCH 2/2] Update glfw.py --- imgui/integrations/glfw.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/imgui/integrations/glfw.py b/imgui/integrations/glfw.py index 1a180df1..823277be 100644 --- a/imgui/integrations/glfw.py +++ b/imgui/integrations/glfw.py @@ -8,7 +8,7 @@ from .opengl import ProgrammablePipelineRenderer class GlfwRenderer(ProgrammablePipelineRenderer): - def __init__(self, window, attach_callbacks=True: "False to use your own callbacks"): + def __init__(self, window, attach_callbacks:"False to use your own callbacks"=True): super(GlfwRenderer, self).__init__() self.window = window