New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSX, PyQt5: find_qmake_path fails because it doesn't include the bin directory #2220

Closed
devvmh opened this Issue Oct 11, 2016 · 1 comment

Comments

Projects
None yet
3 participants
@devvmh

devvmh commented Oct 11, 2016

I am building an app using the develop branch of pyinstaller. I stepped through hook-PyQt5.QtWebEngineWidgets.py to see why QtWebEngineCore wasn't working, and I noticed that get_qmake_path was failing. I'm able to work around this issue by using the QT5DIR environment variable, but I thought I'd report this.

I think the following solution would work, but I'm not very familiar with the codebase at all, so I'm submitting this as an issue and not a PR. I could submit a PR if this solution looks correct.

In PyInstaller/utils/hooks/qt.py on line 160, change this line:

-           qmake = os.path.join(directory, 'qmake')
+           qmake = os.path.join(directory, 'bin', 'qmake')

PS: I'm using Python, qt, and PyQt5 from

brew install python3 qt5 pyqt5

and pyinstaller from

pip3 install git+git://github.com/pyinstaller/pyinstaller.git@5812b64470e2232f6b6f8f68c81dc220b2aedfd7

@devvmh devvmh changed the title from find_qmake_path fails because it doesn't include the bin directory to OSX: find_qmake_path fails because it doesn't include the bin directory Oct 17, 2016

@devvmh devvmh changed the title from OSX: find_qmake_path fails because it doesn't include the bin directory to OSX, PyQt5: find_qmake_path fails because it doesn't include the bin directory Oct 17, 2016

@bjones1

This comment has been minimized.

Member

bjones1 commented Jan 31, 2018

I'm closing this, since #3233 should fix it -- see the instructions there.

@bjones1 bjones1 closed this Jan 31, 2018

@htgoebel htgoebel added this to the PyInstaller 3.4 milestone Sep 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment