Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Drop undocumened "feature" of destination-path for `--add-data` and `--add-binary`? #3066
Currently (v3.3), the destination-path
The destination-path (second element) can be an empty string, in which case the target directory's name is the source directory's basename.
I propose to remove this behavior. Instead, if an empty string is passed, PyInstaller should terminate with a useful message. E.g.
What do you think?
(*) To be more precise: The behavior of the empty string only documented in the code, but the manual does not mention it. Also the manual does not contain an example with an empty target path.
FIne by me. Minor comments on the message. One, it should use the same term as in the docs, which is consistently "DEST" ("--add-binaries SRC:DEST"). Two, I do not understand suggesting
Another bit of tidy-up (maybe need a different issue#) would be to clarify the sections Adding Data Files and Adding Binary Files by using the terms "SRC" and "DEST" in those sections. That would more clearly associate them to the command syntax used earlier in the manual.