Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooks: update Gst and GdkPixbuf to work on msys2 #3387

Merged
merged 3 commits into from Mar 13, 2018

Conversation

virtuald
Copy link
Contributor

@virtuald virtuald commented Mar 9, 2018

Tested on msys2 and Fedora. Probably fixes #3257.

- Explicitly look for library files, as msys2 puts in .a files that cause errors
@virtuald virtuald force-pushed the gdk-gst-fixes branch 2 times, most recently from 5e66992 to ebc7fd6 Compare March 10, 2018 06:09
@htgoebel
Copy link
Member

Thanks for this pull-request. It looks like this is also includes some other optimizations. May I ask you to split these into a commit of its own? Thanks a lot.

@htgoebel htgoebel added this to the PyInstaller 3.4 milestone Mar 10, 2018
@htgoebel htgoebel added the area:hooks Caused by or effecting some hook label Mar 10, 2018
@virtuald
Copy link
Contributor Author

Which particular lines look like optimizations? Are you referring to extracting the path out into variables at the top of the file?

@htgoebel
Copy link
Member

Yes. These look to be clean-up but no functional changes.

- The loaders used to be static, now it seems to be copied to a weird location
- Move the output directory to match what GdkPixbuf installs to
@virtuald
Copy link
Contributor Author

Done again.

@htgoebel htgoebel merged commit 13023fc into pyinstaller:develop Mar 13, 2018
@htgoebel
Copy link
Member

Perfect :-) Thanks!

@virtuald virtuald deleted the gdk-gst-fixes branch June 29, 2018 15:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area:hooks Caused by or effecting some hook
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Freezing a PyGI app - Part 4
2 participants