hooks: Add "sqlalchemy.ext.baked" to sqlalchemy hook. #5128
Conversation
There was a problem hiding this comment.
This also needs a news entry. The README in the hooks repo actually explains it much better. But you should add your entry to this repo's news folder and include it in this PR.
rizsyed1
force-pushed
the
add-sqlalchemy-hidden-import-final
branch
from
4736cb4
to
0afb7d1
Compare
|
@Legorooj Mind giving this a check too? |
|
Actually hold on. CI is failing. |
|
@bwoodsend @rs357 yep - fix CI and then this is good to go. |
|
Also Travis is acting up but it looks irrelevant? |
|
Errm it looks irrelevant hence it probably not being. I'll take a look tomorrow. |
For issue pyinstaller#5106, added "sqlalchemy.ext.baked" to the hidden imports list of sqlalchemy hook file hook-sqlalchemy.py. This is because it was missing.
rizsyed1
force-pushed
the
add-sqlalchemy-hidden-import-final
branch
from
0afb7d1
to
b7d00ae
Compare
|
Also see #4920 Maybe also we want to ask sqlalchamy maintainers to provide the hook with there package? |
Suggestion committed Co-authored-by: Legorooj <50370070+Legorooj@users.noreply.github.com>
News update commit Co-authored-by: Brénainn Woodsend <30940778+bwoodsend@users.noreply.github.com>
|
Hi @Legorooj and @bwoodsend - I used the 'commit suggestion' option in the GitHub UI to commit your changes, and mentioned that I had done so in the commit messages. To my understanding, commit messages are squashed and edited at the maintainer end anyway. Is this alright? If not then I can make the changes in my local repo, squash the commits to a nice message and push. |
|
Yeah, we'll squash them so don't worry about commit history. |
Suggestion Committed Co-authored-by: Legorooj <50370070+Legorooj@users.noreply.github.com>
Closes #5106, added "sqlalchemy.ext.baked" to the hidden imports
list of sqlalchemy hook file hook-sqlalchemy.py. This is because it was
missing.