New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openpyxl hook #2066

Merged
merged 1 commit into from Jul 22, 2016

Conversation

Projects
None yet
4 participants
@stephenrauch
Copy link
Contributor

stephenrauch commented Jun 25, 2016

Hook to address #1890

@beargan

This comment has been minimized.

Copy link

beargan commented Jun 28, 2016

@stephenrauch thanks.
your method is feasible.

@bjones1

This comment has been minimized.

Copy link
Member

bjones1 commented Jul 12, 2016

@stephenrauch, thanks! Would you mind either providing a test case or some code that fails in a comment below?

@stephenrauch

This comment has been minimized.

Copy link
Contributor Author

stephenrauch commented Jul 12, 2016

import openpyxl
print openpyxl.__version__

@stephenrauch stephenrauch force-pushed the stephenrauch:openpyxl-hook branch from 7b0f45f to 10c4625 Jul 15, 2016

@stephenrauch

This comment has been minimized.

Copy link
Contributor Author

stephenrauch commented Jul 15, 2016

@bjones1

OK, if you insist, here is the version with a test case... 😄

Sorry it did not occur to me the first time around. My only excuse is that it was late that night...

@stephenrauch

This comment has been minimized.

Copy link
Contributor Author

stephenrauch commented Jul 15, 2016

Lovely,

I add a test case and appveyor blows up before it even gets to the test cases because pip blows a gasket? Ouch.

@bjones1

This comment has been minimized.

Copy link
Member

bjones1 commented Jul 15, 2016

Aargh, I have no idea why pip died. Thanks for adding the test case -- I'm busy with other projects and just haven't had the time...

@htgoebel htgoebel added the hooks label Jul 17, 2016

@htgoebel

This comment has been minimized.

Copy link
Member

htgoebel commented Jul 17, 2016

Thanks for this hook. Please add an URL for openyxl since it is not commonly known and which version you tested this hook with. See hook-distorm3.py as an example. Thanks.

@htgoebel htgoebel self-assigned this Jul 17, 2016

@stephenrauch

This comment has been minimized.

Copy link
Contributor Author

stephenrauch commented Jul 17, 2016

I really have no idea what version I used, I simply did a pip install openpyxl in response to the bug being filed to see if I could help out. The problem presented itself in a quick test, and so I coded and submitted the hook.

@htgoebel

This comment has been minimized.

Copy link
Member

htgoebel commented Jul 19, 2016

pip list | grep openpyxl is your friend :-)

This version info showed to up to be useful. This is why I'm insisting on it.

@stephenrauch

This comment has been minimized.

Copy link
Contributor Author

stephenrauch commented Jul 19, 2016

Oh, if it were only that easy...

C:\>pip list | grep openpyxl
'grep' is not recognized as an internal or external command,
operable program or batch file.
@htgoebel

This comment has been minimized.

Copy link
Member

htgoebel commented Jul 19, 2016

@stephenrauch IC, you are using an outdated operating system ;-)

@bjones1

This comment has been minimized.

Copy link
Member

bjones1 commented Jul 19, 2016

Does pip show openpyxl work?

@stephenrauch

This comment has been minimized.

Copy link
Contributor Author

stephenrauch commented Jul 19, 2016

@bjones1

Thanks,

I will be able to get the version with no issues, I am just super busy lately, and was mostly just teasing @htgoebel. I think he got it when he threw that dig in at my workstation OS of choice. It is all good and I should get a chance to make the requested change before too much longer.

That however still doesn't help with the errant appveyor...

@bjones1

This comment has been minimized.

Copy link
Member

bjones1 commented Jul 19, 2016

@stephenrauch, any help is welcome in Appveyor fixes -- see #2100...

@stephenrauch stephenrauch force-pushed the stephenrauch:openpyxl-hook branch from 10c4625 to 1dbb921 Jul 20, 2016

@htgoebel

This comment has been minimized.

Copy link
Member

htgoebel commented Jul 22, 2016

I [...] was mostly just teasing @htgoebel. I think he got it when he threw that dig in at my workstation OS of choice.

Yes, I got it ;-)

Thanks for updating the pull-request.

And thanks for competently answering quite some of the issue ticket. It's very helpful for us!

@htgoebel htgoebel merged commit df72fb8 into pyinstaller:develop Jul 22, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details

@htgoebel htgoebel added this to the PyInstaller 3.3 milestone Jul 22, 2016

@stephenrauch stephenrauch deleted the stephenrauch:openpyxl-hook branch Jul 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment