Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: enable flake8 #2778

Closed
wants to merge 10 commits into from
Closed

tests: enable flake8 #2778

wants to merge 10 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 27, 2017

This enables automatic checking of the diffs to ensure PEP8 compliance. Existing code is not affected.

@ghost
Copy link
Author

ghost commented Aug 27, 2017

Evidence that this works:

https://travis-ci.org/xoviat/pyinstaller/jobs/268816597

Rather than only running the linter against the develop branch, we run the linter against all PRs and automatically set the branch.
@ghost ghost closed this Aug 28, 2017
@ghost ghost reopened this Aug 28, 2017
@ghost ghost closed this Aug 28, 2017
@ghost ghost deleted the flake8 branch August 28, 2017 18:38
@ghost ghost restored the flake8 branch August 28, 2017 20:54
@ghost ghost reopened this Aug 28, 2017
@ghost
Copy link
Author

ghost commented Aug 29, 2017

Reason for the changes: flake8 now is automatically run only for pull requests and automatically against the correct pull request branch.

@htgoebel
Copy link
Member

I now found time to look at this – I thought, it would be much more complicate, otherwise I would have reviewed it earlier.

Is there a special reason why the "lint" step is run on all oses and with all versions? I'd thought it would be okay to run it once.

@htgoebel
Copy link
Member

Needs to be run on all versions:

It is very important to install Flake8 on the correct version of Python for your needs. If you want Flake8 to properly parse new language features in Python 3.5 (for example), you need it to be installed on 3.5 for Flake8 to understand those features. In many ways, Flake8 is tied to the version of Python on which it runs.

But I assume we can save OS X (we do not test on Windows, either)

@htgoebel
Copy link
Member

Superseded by #2864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants