New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: enable flake8 #2778
tests: enable flake8 #2778
Conversation
Evidence that this works: |
Rather than only running the linter against the develop branch, we run the linter against all PRs and automatically set the branch.
Reason for the changes: flake8 now is automatically run only for pull requests and automatically against the correct pull request branch. |
I now found time to look at this – I thought, it would be much more complicate, otherwise I would have reviewed it earlier. Is there a special reason why the "lint" step is run on all oses and with all versions? I'd thought it would be okay to run it once. |
Needs to be run on all versions:
But I assume we can save OS X (we do not test on Windows, either) |
Superseded by #2864 |
This enables automatic checking of the diffs to ensure PEP8 compliance. Existing code is not affected.