New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2633: Resolve library name reported by usb.backend in hook-usb #2831

Merged
merged 2 commits into from Feb 25, 2018

Conversation

Projects
None yet
4 participants
@themadinventor
Contributor

themadinventor commented Sep 15, 2017

hook-usb.py "asks" pyusb which library to pack by inspecting usb.backend. This only result in a library name (e.g libusb-1.0.so.0), which is sufficient for ctypes to load the library, but not enough for pyinstaller to find the file and pack it.
This fix solves this problem by using _resolveCtypesImports to figure out the full path to the file pyusb loads.

@htgoebel htgoebel added the hooks label Sep 15, 2017

@jxltom

This comment has been minimized.

jxltom commented on 5de8a59 Jan 16, 2018

In Linux it works fine. In Windows 7 Enterprise, assert len(binaries[0]) == 3 fails when using Conda's python35 env with libusb...

This comment has been minimized.

Member

htgoebel replied Jan 16, 2018

@jxltom Please open an issue providing all information required for analysis, esp. the traceback.

This comment has been minimized.

hu7241 replied Feb 6, 2018

Works under Linux for Python 2.7 and Pyinstaller 3.2.1. Many thanks.

@htgoebel htgoebel merged commit 4218c19 into pyinstaller:develop Feb 25, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@htgoebel

This comment has been minimized.

Member

htgoebel commented Feb 25, 2018

Thanks for thi pull-request. I finally found time for merging it.

@themadinventor

This comment has been minimized.

Contributor

themadinventor commented Feb 26, 2018

I'm happy to contribute. Thank you for maintaining pyinstaller!

@htgoebel htgoebel added this to the PyInstaller 3.4 milestone Sep 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment