New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooks: Add hook-pandas.py to fix issue #2978. #2998

Merged
merged 1 commit into from Mar 13, 2018

Conversation

Projects
None yet
5 participants
@lneuhaus
Contributor

lneuhaus commented Nov 14, 2017

pandas>=0.21 has a hidden import of "pandas._libs.tslibs.timedeltas.so".

Hooks: Add hook-pandas.py to fix issue #2978.
pandas>=0.21 has a hidden import of "pandas._libs.tslibs.timedeltas.so".
@lneuhaus

This comment has been minimized.

Contributor

lneuhaus commented Nov 19, 2017

I do not really understand why tests are failing. Can someone confirm that this is the fault of my fix?

@htgoebel

This comment has been minimized.

Member

htgoebel commented Nov 19, 2017

The job exceeded the maximum time limit for jobs, and has been terminated.

I restarted the job. We'll see.

@lneuhaus

This comment has been minimized.

Contributor

lneuhaus commented Dec 8, 2017

while it looks here that the test failed, it actually passed:

So: does anything speak against merging this PR?

@htgoebel htgoebel merged commit f1824d6 into pyinstaller:develop Mar 13, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@htgoebel htgoebel added this to the PyInstaller 3.4 milestone Mar 13, 2018

@luwii

This comment has been minimized.

luwii commented Apr 1, 2018

Thanks for posting, I spent ages and it started driving me mad before I stumbled on this. Worked like charm to fix pyinstaller program.py Does not seem to be working with pyinstaller -F program.py but I can live with it. Thanks!

@maichm

This comment has been minimized.

maichm commented Apr 9, 2018

when run pyinstaller -F xxx.py in windows10 , I get error AttributeError: type object 'pandas._libs.tslib._TSObject' has no attribute '__reduce_cython__', and solve it by degrade pandas version to 0.20.0.

@jni

This comment has been minimized.

jni commented May 17, 2018

Has anyone come up with a workaround that works with -F and a recent pandas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment