New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests/CI: Significantly clean-up appveyor #3107

Merged
merged 3 commits into from Dec 15, 2017

Conversation

Projects
None yet
1 participant
@ghost

ghost commented Dec 13, 2017

Much of the appveyor file assumed that parallel testing was not
enabled and/or %CMD_IN_ENV% was required. These issues have
been resolved.

xoviat
Tests/CI: Significantly clean-up appveyor
Much of the appveyor file assumed that parallel testing was not
enabled and/or %CMD_IN_ENV% was required. These issues have
been resolved.
@@ -7,87 +7,34 @@ branches:
except:
- /pyup\/.*/
# No reason for us to restrict the number concurrent jobs
max_jobs: 100

This comment has been minimized.

@ghost

ghost Dec 13, 2017

And no, this makes no difference.

@htgoebel

This comment has been minimized.

Member

htgoebel commented Dec 15, 2017

Do I understand this correctly: Since parallel testing in appveyor now works, there is no longer a need to split testing between unit-tests and the library.

This is fine.

But I do not understand why this %CMD_IN_ENV% is not longer required.

Also if tests\scripts\appveyor\run_with_env.cmd now is no longer needed, this file should be removed, too.

@ghost

This comment has been minimized.

ghost commented Dec 15, 2017

CMD_IN_ENV was an early workaround that is no longer needed with the advent of setuptools.

xoviat added some commits Dec 15, 2017

xoviat
xoviat
@ghost

This comment has been minimized.

ghost commented Dec 15, 2017

Anything else you want removed?

@htgoebel htgoebel merged commit ab8fd97 into pyinstaller:develop Dec 15, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@ghost ghost deleted the appveyor-cleanup branch Dec 15, 2017

@htgoebel

This comment has been minimized.

Member

htgoebel commented Dec 15, 2017

@xoviat That's fine for me, Thanks :) You even spotted unused install.ps1 still being present.

@ghost

This comment has been minimized.

ghost commented Dec 15, 2017

Unfortunately, this will result in failing tests (see e552502#commitcomment-26308884). Sorry about that.

@htgoebel htgoebel added this to the PyInstaller 3.4 milestone Sep 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment