New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests/CI: clean-up travis.yml #3108

Merged
merged 2 commits into from Dec 15, 2017

Conversation

Projects
None yet
1 participant
@ghost

ghost commented Dec 13, 2017

The need for the cache stage is now questionable because
the PyInstaller build stage has enough extra time to cache
dependencies that need to be compiled. Also, there's only
a need for linting Python 2.7 and Python 3.6 because the
syntax is all the same on Python 3.

Closes #2865.

xoviat
Tests/CI: clean-up travis.yml
The need for the cache stage is now questionable because
the PyInstaller build stage has enough extra time to cache
dependencies that need to be compiled. Also, there's only
a need for linting Python 2.7 and Python 3.6 because the
syntax is all the same on Python 3.
@ghost

This comment has been minimized.

ghost commented Dec 14, 2017

@htgoebel Merge?

@htgoebel

This comment has been minimized.

Member

htgoebel commented Dec 14, 2017

Just after the 3.3.1 release.

xoviat
@htgoebel

This comment has been minimized.

Member

htgoebel commented Dec 15, 2017

Cleaning up and removing unnecessary stuff is a good thing.

Regarding this very change: I'm not a travis expert and it confuses me a bit:

  • Why there is no install : in OS X Test - Libraries, while you needed to add a install: for Lint?
  • Is the "global" install required at all? Looks redundant.

Maybe we could take the chance for some more cleanup: The jobs definitions for OS X seem to be largely redundant with those for Linux. What do you think about building all jobs based on the OS X one? Maybe like this:

    - &test-pyinstaller-osx
      stage: Test - PyInstaller
      os: osx
        …
    - &test-pyinstaller
      <<: *test-pyinstaller-osx
      python: 2.7
      os: linux
       …

(Of course, other things need to be overwritten, eg, cache, but a lot of stuff should be redundant.)

What do you think?

@ghost

This comment has been minimized.

ghost commented Dec 15, 2017

Not worth spending too much time on this. The cleanup is mainly to improve build speed.

@ghost

This comment has been minimized.

ghost commented Dec 15, 2017

This is ready. We can always further clean-up later, but improved build speed is worth it now.

@htgoebel htgoebel added the tests/ci label Dec 15, 2017

@htgoebel htgoebel merged commit 1981f95 into pyinstaller:develop Dec 15, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ghost ghost deleted the travis-cleanup branch Dec 15, 2017

@htgoebel

This comment has been minimized.

Member

htgoebel commented Dec 15, 2017

Normally I dislike "can clean up later" changes, but I'll make an exception on this.

@htgoebel htgoebel added this to the PyInstaller 3.4 milestone Sep 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment