Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Hint users to install development package for missing `pyconfig.h` #3348
referenced this pull request
Feb 28, 2018
Thanks for this pull-request. Overall it looks good, just a few adjustments to be done.
Also please split the commit into two: One for the functional change and one for gitignore. https://pyinstaller.readthedocs.io/en/latest/development/pull-requests.html#updating-a-pull-request might be of use.
Thanks for trying :-) git is a powerful tool but with power comes complexity.
Wasn't https://pyinstaller.readthedocs.io/en/latest/development/pull-requests.html#updating-a-pull-request helpful? What is missing there?
Sounds good -- looks like I failed the TravisCI linters for a few minor issues, which I've fixed and committed. The other failure in Travis was in the nightly build, regarding CDLL's, which I don't believe has to do with my changes. If I'm wrong, let me know...