New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reword to make clear that --windowed is independent of --onedir #3383

Merged
merged 2 commits into from Mar 13, 2018

Conversation

Projects
None yet
2 participants
@tallforasmurf
Contributor

tallforasmurf commented Mar 8, 2018

No description provided.

@htgoebel

Thanks for this improvement! Now it is quite clear what is going on - even for a non-mäcos-user.

I've just added some mit-pickeing remarks. You may simply push another commit and I'll squash-merge them when.

|PyInstaller| builds minimal versions of these elements.
Use the ``icon=`` argument to specify a custom icon for the application.
It will be copied into the :file:`Resources` folder.
(When you do not specify an icon file, |PyInstaller| supplies a

This comment has been minimized.

@htgoebel

htgoebel Mar 10, 2018

Member

When -> if
no parents.

Standard input and output work as normal through that Terminal window.
If you specify ``--windowed`` with either option, the ``dist`` folder
also contains an OS X application named :file:`myscript.app`.

This comment has been minimized.

@htgoebel

htgoebel Mar 10, 2018

Member

"also"? This means in addition to the file when using --console? May not be worth changing the text, I'm just curious.

This comment has been minimized.

@tallforasmurf

tallforasmurf Mar 11, 2018

Contributor

Yes, it builds the "normal" output (dir or file) and also builds the myscript.app.

+ A folder :file:`Resources` that contains an icon file.
+ A file :file:`Info.plist` that describes the app.
+ A folder :file:`MacOS` that contains the same contents as
the ``--onedir`` bundle.

This comment has been minimized.

@htgoebel

htgoebel Mar 10, 2018

Member

Maybe append "… (see above)"?

This comment has been minimized.

@tallforasmurf

tallforasmurf Mar 11, 2018

Contributor

I will change this wording. It is not important to know that dist/myscript.app/Contents/MacOS/* is a redundant copy of dist/myscript/* Also not something we want to promise in the doc as someday it might not be that way.

@htgoebel htgoebel added this to the PyInstaller 3.4 milestone Mar 10, 2018

Nat Picker

@htgoebel htgoebel merged commit 93630d1 into pyinstaller:develop Mar 13, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
@htgoebel

This comment has been minimized.

Member

htgoebel commented Mar 13, 2018

Thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment