New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooks: update Gst and GdkPixbuf to work on msys2 #3387

Merged
merged 3 commits into from Mar 13, 2018

Conversation

Projects
None yet
2 participants
@virtuald
Contributor

virtuald commented Mar 9, 2018

Tested on msys2 and Fedora. Probably fixes #3257.

Hooks: adjust gstreamer plugins
- Explicitly look for library files, as msys2 puts in .a files that cause errors

@virtuald virtuald force-pushed the virtuald:gdk-gst-fixes branch 2 times, most recently from 5e66992 to ebc7fd6 Mar 9, 2018

@htgoebel

This comment has been minimized.

Member

htgoebel commented Mar 10, 2018

Thanks for this pull-request. It looks like this is also includes some other optimizations. May I ask you to split these into a commit of its own? Thanks a lot.

@htgoebel htgoebel added this to the PyInstaller 3.4 milestone Mar 10, 2018

@htgoebel htgoebel added the hooks label Mar 10, 2018

@virtuald

This comment has been minimized.

Contributor

virtuald commented Mar 11, 2018

Which particular lines look like optimizations? Are you referring to extracting the path out into variables at the top of the file?

@htgoebel

This comment has been minimized.

Member

htgoebel commented Mar 12, 2018

Yes. These look to be clean-up but no functional changes.

virtuald added some commits Mar 13, 2018

Hooks: fix GdkPixbuf to work on newer msys2
- The loaders used to be static, now it seems to be copied to a weird location
- Move the output directory to match what GdkPixbuf installs to

@virtuald virtuald force-pushed the virtuald:gdk-gst-fixes branch from ebc7fd6 to 802f003 Mar 13, 2018

@virtuald

This comment has been minimized.

Contributor

virtuald commented Mar 13, 2018

Done again.

@htgoebel htgoebel merged commit 13023fc into pyinstaller:develop Mar 13, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
@htgoebel

This comment has been minimized.

Member

htgoebel commented Mar 13, 2018

Perfect :-) Thanks!

@virtuald virtuald deleted the virtuald:gdk-gst-fixes branch Jun 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment