New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing warnings module in base_library.zip #3400

Merged
merged 1 commit into from Mar 13, 2018

Conversation

Projects
None yet
2 participants
@mnencia
Contributor

mnencia commented Mar 12, 2018

When you use the -W option to python interpreter some of the modules
present in base_library.zip requires the warnings module, raising an
error. The issue is solved by adding it to the PY3_BASE_MODULES set.

Closes: #3397

Add missing warnings module in base_library.zip
When you use the -W option to python interpreter some of the modules
present in base_library.zip requires the warnings module, raising an
error. The issue is solved by adding it to the PY3_BASE_MODULES set.

Closes: #3397
@htgoebel

This comment has been minimized.

Member

htgoebel commented Mar 13, 2018

Thanks for this pull-request :-)

I was about to suggest adding a test-case, when I found tests/functional/test_basic.py::test_option_w_ignore, which already does what I would have suggested to test. This test-case did not detect the issue and needs to be improved, see #3402

@htgoebel htgoebel merged commit f101f6f into pyinstaller:develop Mar 13, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@htgoebel htgoebel added this to the PyInstaller 3.4 milestone Mar 13, 2018

@mnencia mnencia deleted the mnencia:missing-warnings branch Mar 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment