New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of the addition of resources for Windows executables #3423

Merged
merged 2 commits into from May 27, 2018

Conversation

Projects
None yet
3 participants
@ethframe
Contributor

ethframe commented Mar 23, 2018

I have faced issue that PyInstaller crashes when trying to add resources to Windows executable using --resource option. This pull request contains minimal fix tested on Python 2.7.14 and 3.6.3.

There is also an issue proposing the same fix: #2675

@htgoebel

Thanks for implementing this :-)
Just one question, see in-line comment.

Show resolved Hide resolved PyInstaller/utils/win32/winresource.py

@htgoebel htgoebel merged commit 88bf61a into pyinstaller:develop May 27, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@htgoebel htgoebel added this to the PyInstaller 3.4 milestone Sep 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment