Join GitHub today
Hooks: Update PyQt5 hooks #3439
just fyi I gave it a run with the infamous minweb and it still fails as before, failing to find
referenced this pull request
Apr 4, 2018
I have two questions about this PR, but first some background.
I have not been able to package a PyQt5 QML application. This is the application I am testing https://github.com/Siecje/qml-testing/blob/PyInstaller/main.spec
I am on Windows 7 32-bit with Python 3.4.4.
I installed pywin32 using the wheel from https://www.lfd.uci.edu/~gohlke/pythonlibs/#pywin32
I have compiled PyQt5 from source (there is no wheel for Python 3.4).
In order for the application to work on another computer I have to set two environment variables.
set QT_QPA_PLATFORM_PLUGIN_PATH=%INSTALL_DIR%\PyQt5\Qt\plugins\platforms set QML2_IMPORT_PATH=%INSTALL_DIR%\qml
The current version of PyInstaller puts the .qml files into a
This PR is setting it to a different directory.
I assume it is different because it is from a PyQt5 install from source.
Is this difference also fixed in this PR?
This PR is not setting
@bjones1 Is there really a need for me to review again? If you addressed all my comments (or decided not to do), this should be fine.
Except of some severe errors pylint reports (see https://travis-ci.org/pyinstaller/pyinstaller/jobs/361343548 and https://travis-ci.org/pyinstaller/pyinstaller/jobs/361343549): some syntax errors and some very long lines. (No need to address all the lint-errors, esp. if the code would become less readable when following them :-)
If you handled the pylint, this is fine for me. Since you said, I'd like to rebase, I suggest merging with