Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix to show utf-8 debug messages correctly(noconsole mode)/convert to… #3477
… mbcs strings before write to stderr(console mode) on Windows.
Until this patch applied, all non-ASCII messages are failed to show(mojibake).
Note1: waf build system has a bug to detect MSVC with Japanese (or DBCS localized) version of Windows.
htgoebel left a comment
Thanks for this pull-request. I added some comments and requests for enhancement.
Please also rework the commits and the commit message following the https://pyinstaller.readthedocs.io/en/latest/development/commit-messages.html. I think Note 2 is worth going into the commit message body. Thanks.
Thanks for the comments. I'm looking forward to your update :-)
When updating a pull-request, you can simply (force) push the updated branch to github again. This will automatically update the pull-request (which follows the branch, not the commit). So you do not need to close the pull-request and open a new one. This also has the benefit that the discussion history is kept. For detailed instructions please read Updating a Pull-Request in the manual.
htgoebel left a comment •
It will be 'patterned' garbage. That would be the hint of what the real message is. I think this garbage is better than the messages which don't have the given string.
Because I told above, I won't fix this
Ok, I'll do after your answer to the my asks at the first and last of this post.
See Language Identifier Constants and Strings on MSDN. We should use
referenced this pull request
Jul 6, 2018
Please abstain from merging other branches into the branch this pull-request is based on. This will make it impossible to review. If you really need to check if your code works with current development head, please rebase on develop. But be aware that his will destroy the discussion history, So typically this is done after the code-review passed.