Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix to use UTF-8 while reading XML manifest file. #3478
referenced this pull request
Apr 23, 2018
Sorry to my panic with this pull request.
And I have another question about test.
You said XML manifest related code should be tested not only under Microsoft Windows but also another environments. But today, Travis CI reports like below:
I think this means that
Sorry for not answering earlier, I'm very busy in my day job.
Since this manifest-code is Windows only, the test can safely be restricted to windows only, too. For this
If tests pass, please clean up the pull-request - which in the case means: rebase on current deveop head and squash into a single commit. Please reword the commit message to comply to our Commit Message Rules.
You also need to submit a changelog entry so our users can learn about your change. (This is a new requirement since last September to speed up releasing.)
When updating a pull-request, you can simply (force) push the updated branch to github again. This will automatically update the pull-request (which follows the branch, not the commit). So you do not need to close the pull-request and open a new one. This also has the benefit that the discussion history is kept. For detailed instructions please read Updating a Pull-Request in the manual.