Join GitHub today
Bootloader: forward signals to bundled application #3515
Forward more signals
All the signals, to be precise. (Well, all the signals that can be handled.)
If the caller of
Note: docs forthcoming for the new flag (and perhaps this overall behavior), pending feedback on the overall approach.
New functional test
This test checks whether signals sent to an pyinstaller-built executable can be handled
Summary of my manual testing so far (before this test):
At present, I'm assuming that an application using pyinstaller could reasonably want to handle any handleable signal (i.e. not SIGKILL or SIGSTOP). If there are any exceptions to this, or if this needs to be handled more selectively for reasons I'm not aware of, I'd be glad to hear about it.
changed the title from
WIP: Bootloader: forward signals to
WIP: Bootloader: forward signals to bundled application
May 15, 2018
There's a subtle problem with this PR: messing with SIGCHLD makes the boot loader unable to
I have a fix in flight; will hopefully push soon, along with a related piece of functionality that I think is required here (the ability to ignore signals in the boot loader if desired).
I'm currently stuck on this issue: I have a test that breaks with
I've just pushed the branch in its current broken state to show what I mean. Suggestions welcome.
If the failure in Travis looks like my local testing, it'll show that the call to
But, I've also been seeing strange results where debug prints that I insert in the parent don't show up in the output, even though the child process is still forked and runs the test. So there might be something wonky with my test environment. I'm very curious to see what the same test in Travis looks like.
Thanks a lot for this pull-request. Sorry for not answering earlier, I'm busy with my day-job.
This looks good for me and I like the test-suite you've created. Nevertheless I added some comments, most of which are nit-picking to keep the code maintainable for another 10 years.