New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incompatibility with `pycryptodome` #3537

Merged
merged 1 commit into from May 27, 2018

Conversation

Projects
None yet
2 participants
@pwuertz
Contributor

pwuertz commented May 25, 2018

The pycryptodome library is a replacement for the (apparently abandoned) pycrypto library, which is a bit more picky concerning the key type. It isn't accepting str anymore and requires a byte array to be passed to the C function. This is fixed by simply calling encode on the string. This still works with the old pycrypto library.

Fix incompatibility with `pycryptodome`
The `pycryptodome` library is a replacement for the (apparently abandoned) `pycrypto` library, which is a bit more picky concerning the `key` type. It isn't accepting `str` anymore and requires a byte array to be passed to the C function. This is fixed by simply calling encode on the string. This still works with the old `pycrypto` library.

@htgoebel htgoebel merged commit d4cc9fe into pyinstaller:develop May 27, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@htgoebel htgoebel added this to the PyInstaller 3.4 milestone Sep 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment