Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Bootloader: OSX: Respect Info.plist options #3566
A possible fix for #1917.
What is the fix/workaround?
This is the simplest option as it does not require to add new bootloaders nor a new argument to handle this specific case. The behavior is restored as it should have been: when the user sets
The patch is good but does not work automatically because the TOC option is not yet forwarded to the bootloader.
As we can see, the line
Any clue to make it easy forwarded? Perhaps I misunderstand something?
All of these options have to be present when the PKG is build (which is triggered by the
EXE). So I'm afraid we need to add another keyword argument to
EXE, like it is done in a582974.
To avoid the need for the developer to handle this twice, you could add an entry to
self.info_plist around here. If info_plist contains a contradicting entry, raise an error.
I also marked some code issues already.
changed the title from
MacOS: Respect the LSUIElement=1 plist option
[WIP] MacOS: Respect the LSUIElement=1 plist option
Jun 12, 2018
I updated the PR, it is working now.
I don't know if I had to add the
Also, should I include updated bootloaders?
Let me know your thoughts, do not hesitate to ask for minor changes (even in logged sentences). When it will be OK, I will add documentation and test cases.
Finally I found a way simpler fix: by not calling ourselves
I think we have the desired behavior. Same results with
I am open to any advice/review to ensure I did not break something.
For testing, you can use these files:
I would prefer to have this two commits: One for the Bootloader change and one for "Automatically set Info.plist LSBackgroundOnly=True when consol…".
Please do not build bootloaders, we have the policy that only bootloaders compiled by core develeopers are commited. And we need to recompile all of then soon anyway due to the upcoming Python 3.7 release.
Thanks for the update. Looks good to me. Only one small suggestion.