New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooks: Place PyQt5 DLLs in the correct location #3583

Merged
merged 1 commit into from Jun 20, 2018

Conversation

Projects
None yet
3 participants
@Siecje
Contributor

Siecje commented Jun 19, 2018

@bjones1

opengl32sw.dll was being copied into PyQt5\Qt\bin\opengl32sw.dll\opengl32sw.dll so it was creating the destination as a directory and then copying the file into it.

This is what binaries contained for me.

>>> binaries
[('C:/users/testvm/desktop/gui/venv/lib/site-packages/PyQt5/Qt/bin\\opengl32sw.dll', 'PyQt5\\Qt\\bin\\opengl32sw.dll')]

@bjones1 bjones1 merged commit 7cd2fc9 into pyinstaller:develop Jun 20, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bjones1

This comment has been minimized.

Member

bjones1 commented Jun 20, 2018

Thanks for this fix!

@htgoebel htgoebel added this to the PyInstaller 3.4 milestone Sep 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment