New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for bokeh visualization library #3607

Merged
merged 1 commit into from Jul 2, 2018

Conversation

Projects
None yet
4 participants
@axil
Contributor

axil commented Jun 29, 2018

Hook for packaging bokeh (https://bokeh.pydata.org/en/latest/) applications.

@axil

This comment has been minimized.

Contributor

axil commented Jul 2, 2018

Minimal working example: https://github.com/axil/frozen_sliders

@htgoebel htgoebel merged commit 4a17827 into pyinstaller:develop Jul 2, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@htgoebel

This comment has been minimized.

Member

htgoebel commented Jul 2, 2018

Thanks you very much :-)

@htgoebel htgoebel added the hooks label Jul 2, 2018

@htgoebel htgoebel added this to the PyInstaller 3.4 milestone Jul 2, 2018

@bryevdv

This comment has been minimized.

bryevdv commented Oct 13, 2018

FYI I think this needs to be updated to include bokeh.themes since Bokeh currently loads JSON theme files from there on init. I have very limited experience with pyinstaller but it appears on master that the missing theme files are causing issue:

  File "/Users/bryanv/anaconda/lib/python3.7/site-packages/PyInstaller/loader/pyimod03_importers.py", line 627, in exec_module
    exec(bytecode, module.__dict__)
  File "bokeh/themes/__init__.py", line 19, in <module>
  File "bokeh/themes/theme.py", line 139, in __init__
FileNotFoundError: [Errno 2] No such file or directory: '/Users/bryanv/work/bokeh/examples/plotting/file/dist/iris/bokeh/themes/light_minimal.json'
[52053] Failed to execute script iris

Edit: Update, I have changed Bokeh to load themes from python modules instead of external files, this will be the way from 1.0 forward.

@bjones1

This comment has been minimized.

Member

bjones1 commented Oct 15, 2018

Thanks for the report. Would you provide a short script that reproduces this? Is it as simple as import bokeh?

For the hook, what's best -- load the themes for now, then remove this load when you release 1.0?

@bryevdv

This comment has been minimized.

bryevdv commented Oct 15, 2018

Here is a simple example:

https://github.com/bokeh/bokeh/blob/master/examples/plotting/file/color_scatter.py

I don't have an opinion or recommendation for how pyinstaller should proceed. The next release should be out next week, in case that is useful information.

@bjones1

This comment has been minimized.

Member

bjones1 commented Oct 15, 2018

Choosing the path of laziness, I'll simply wait for your next release instead of updating the hook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment