Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
added a hook for nltk for PyInstaller/hooks/hook-nltk.py #3705
Thanks for the pull-request. sadly it does not follow our style give, Please fit the errors reported in https://travis-ci.org/pyinstaller/pyinstaller/builds/423358341
When updating a pull-request, you can simply (force) push the updated branch to github again. This will automatically update the pull-request (which follows the branch, not the commit). So you do not need to close the pull-request and open a new one. This also has the benefit that the discussion history is kept. For detailed instructions please read Updating a Pull-Request in the manual.
Sep 9, 2018
Thanks @brightening-eyes for the hook. Just FYI this throws many errors (I'm on Windows 10):
Finally, it would be better if the hook is generic (e.g. not all applications need NER) and any customization can be added by another hook by the user.
I'm trying now to modify the code and if I can get to a proper solution I'll create a PR.