Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooks: Fix hook for numpy 1.16 (#3982) #3985

Closed
wants to merge 2 commits into from

Conversation

@lstolcman
Copy link

lstolcman commented Jan 16, 2019

minimal testing executable:

import numpy as np
print(np.array([1,2,3]))

before fix:

Traceback (most recent call last):
  File "test.py", line 1, in <module>
  File "/Users/lstolcman/projects/nptest/.venv/lib/python3.7/site-packages/PyInstaller/loader/pyimod03_importers.py", line 627, in exec_module
    exec(bytecode, module.__dict__)
  File "site-packages/numpy/__init__.py", line 151, in <module>
  File "/Users/lstolcman/projects/nptest/.venv/lib/python3.7/site-packages/PyInstaller/loader/pyimod03_importers.py", line 627, in exec_module
    exec(bytecode, module.__dict__)
  File "site-packages/numpy/ctypeslib.py", line 369, in <module>
  File "site-packages/numpy/ctypeslib.py", line 358, in _get_typecodes
  File "site-packages/numpy/ctypeslib.py", line 358, in <dictcomp>
ModuleNotFoundError: No module named 'numpy.core._dtype_ctypes'
[27719] Failed to execute script test

after fix:
[1 2 3]

fixes #3982

@KmolYuan

This comment has been minimized.

Copy link

KmolYuan commented Jan 20, 2019

@lstolcman Perhaps it should be noted that NumPy has no numpy.core._dtype_ctypes before 1.16.0.

@lstolcman

This comment has been minimized.

Copy link
Author

lstolcman commented Feb 6, 2019

fixed in numpy 1.16.1

@lstolcman lstolcman closed this Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.