Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Clarify "Adding Binary Files" #4476

Merged
merged 2 commits into from Oct 31, 2019

Conversation

@caramelomartins
Copy link
Contributor

caramelomartins commented Oct 16, 2019

Hey,

Have been using PyInstaller for a while and decided, in the spirit of Hacktoberfest, to contribute back to the project. You have been doing incredible work!

I have contributed to other projects, such as pytest, but never to PyInstaller so feel free to correct me if I have made any errors during this flow. I am going to start with a very small change to see how it goes. 馃槃

This commit was prompted by #4283, which reported that the documentation was misleading.

As suggested in the issue, I have added an additional example and made references to "Adding Data Files" in the hopes of making it clearer.

I have tested it according to guidelines found in https://pyinstaller.readthedocs.io/en/latest/development/documention.html.

Hope everything is fine. If you find any issue, please let me know.

Thanks,
Hugo

Closes #4283.

This commit was prompted by #4283, which reported that the
documentation was misleading.

As suggested in the issue, I have added an additional example
and made references to "Adding Data Files" in the hopes of
making it clearer.
@htgoebel htgoebel merged commit e138e24 into pyinstaller:develop Oct 31, 2019
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@htgoebel

This comment has been minimized.

Copy link
Member

htgoebel commented Oct 31, 2019

Thank you very much for this enhancement. Everything is fine with it :-)

@caramelomartins caramelomartins deleted the caramelomartins:4283 branch Oct 31, 2019
@caramelomartins

This comment has been minimized.

Copy link
Contributor Author

caramelomartins commented Oct 31, 2019

@htgoebel Thank you for accepting the PR. Sorry about the wrapping issues. 馃檪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.